Check if the fragment doesnot already have a name #2825
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2825 (2024-03-15T16:28:55Z) ⚙️ JKube E2E Tests (8298951289)
|
|
@amihalfa Welcome, Thanks a lot for contributing to Eclipse JKube 👍, In order to contribute to Eclipse, you would need to create an Eclipse Account and Sign Eclipse Contributor Agreement. Once you've created an eclipse account you would need to update your commit message with a |
|
@amihalfa : Could you please add a unit test for this too? |
amihalfa
force-pushed
the
bugfix/Issue-Fix-#2823-name-enricher-overrides-fragment-name
branch
from
04e48b5
to
50f3cc5
Compare
Signed-off-by: amihalfa <amirouche.halfaoui@rakuten.com>
amihalfa
force-pushed
the
bugfix/Issue-Fix-#2823-name-enricher-overrides-fragment-name
branch
from
50f3cc5
to
fdec19c
Compare
|
@rohanKanojia To be honest, I don't know what to do for the integration test |
|
Deployment and Service get created with opinionated defaults before invoking NameEnricher, Maybe we can modify NameEnricher to use this value to differentiate whether the name inside the current resource is opinionated (generated by plugin) or is actually set by the user? |
|
Polite ping, is this being worked on? |
manusa
added
the
Waiting on feedback
|
Let me pick this up and discuss internally with the team about what needs to be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
NamingEnricher, instead of overriding all the object names by the${jkube.enricher.jkube-name.name}, only overrides name to every object which misses a name.Fixes #2823
Type of change
test, version modification, documentation, etc.)