Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set project encoding to UTF-8 #76

Conversation

fedejeanne
Copy link

It was done using a "Quick Fix" and the value set (UTF-8) is the same value that any other project in the workspace uses. The objective of this commit is to declutter the "Problems" view.

It was done using a "Quick Fix" and the value set (UTF-8) is the same
value that any other project in the workspace uses. The objective of
this commit is to declutter the "Problems" view.
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are adding settings to something that is not even a project!

@fedejeanne
Copy link
Author

You are adding settings to something that is not even a project!

Technically, it is a project:

grafik

It's the parent maven project, a "POM" project.

Do you think the logic in the ValidateProjectEncoding (see this comment) should be changed?

@iloveeclipse
Copy link
Member

It's the parent maven project, a "POM" project.

Sure, but not an Eclipse project.

Do you think the logic in the ValidateProjectEncoding (see this comment) should be changed?

No, I think the logic is fine. You should simply not import this folder as an Eclipse project.

@fedejeanne
Copy link
Author

fedejeanne commented Nov 3, 2023

It's the parent maven project, a "POM" project.

Sure, but not an Eclipse project.

I see, I will withdraw this PR. I still think that if this is the criteria then the ValidateProjectEncoding should at least check the nature of the project and exclude the "pure Maven" projects with a POM-packaging, don't you think?

Do you think the logic in the ValidateProjectEncoding (see this comment) should be changed?

No, I think the logic is fine. You should simply not import this folder as an Eclipse project.

I didn't import them myself, I used the installer (see comment). I hope Ed can fix the issue to prevent this in the future :-)

@fedejeanne fedejeanne closed this Nov 3, 2023
@fedejeanne fedejeanne deleted the enhancements/set_project_encodings_to_utf8 branch November 3, 2023 20:47
@iloveeclipse
Copy link
Member

You didn't get it. This is not a project because in git, there is no ".project" file.
And once again, ValidateProjectEncoding logic is fine. The problem is that you seem to imported lot of folders as projects. Once you do that, locally you personally have projects, where in reality there shouldn't be a project at all.

@fedejeanne
Copy link
Author

👍

The problem is that you seem to imported lot of folders as projects.

Odd, I wasn't even aware that was possible. Thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants