Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Name Recommendation Based on Program-Specific Naming Conventions #825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DongChunHao
Copy link
Contributor

@DongChunHao DongChunHao commented Sep 25, 2023

What it does

How to test

Open"New_configuration", select the field that doesn't follow constant naming convention,click on 'ctrl+1'.

Author checklist

@DongChunHao DongChunHao changed the title first commit Field Name Recommendation Based on Program-Specific Naming Conventions Sep 25, 2023
@DongChunHao
Copy link
Contributor Author

@jjohnstn Please review the PR submitted,thanks. We believe that when more than half of the fields in the program share a common prefix, renaming other fields may require adding a program-specific prefix (especially during the project update process, where all fields may need to be renamed, and suggesting names for renamed fields initially can be challenging). We hope that when developers have already renamed multiple fields and there exists a fixed program prefix, new names for fields can be recommended.

@DongChunHao
Copy link
Contributor Author

@jjohnstn
Please take a look at the submitted pull request and inform me if this PR is reasonable or how to modify it, thanks.

@jjohnstn
Copy link
Contributor

@DongChunHao Will review for M2.

@jjohnstn
Copy link
Contributor

jjohnstn commented Nov 2, 2023

/rebase

Copy link
Contributor

@jjohnstn jjohnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as -1 in case anyone else reviews this. See comments in the issue.

Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rated "limited utility with a possible performance hit."
#661 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants