Enable LeakTestSuite in org.eclipse.jdt.ui.tests pom.xml file again (#2)

[iloveeclipse]

Fixes issue #2

[iloveeclipse]

Some maven tweaking is needed, tests are still failing:

java.lang.RuntimeException: 
JVM settings for --add-modules, --add-opens, and --illegal-access are probably missing.
Exception : 
Unable to make field private static final java.util.Set jdk.nio.zipfs.ZipFileSystem.supportedFileAttributeViews accessible: module jdk.zipfs does not "opens jdk.nio.zipfs" to unnamed module @543315dc
	at org.eclipse.jdt.ui.tests.leaks.JavaLeakTest.testTextEditorCloseOneOfTwo(JavaLeakTest.java:99)
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private static final java.util.Set jdk.nio.zipfs.ZipFileSystem.supportedFileAttributeViews accessible: module jdk.zipfs does not "opens jdk.nio.zipfs" to unnamed module @543315dc
	at org.eclipse.jdt.ui.tests.leaks.JavaLeakTest.testTextEditorCloseOneOfTwo(JavaLeakTest.java:99)

[iloveeclipse]

@ktatavarthi : I have no idea why the test in tycho / jenkins doesn't work now. Any idea?

[ktatavarthi]

@ktatavarthi : I have no idea why the test in tycho / jenkins doesn't work now. Any idea?

I donot have any idea. I will try and check if, I can reproduce this problem locally.

@mickaelistria : Do you have any idea. In one of your previous comment , you said that you were able to run the LeakTestSuite locally using maven successfully.

[mickaelistria]

Indeed, I can run those tests locally with a mvn clean verify from the module (removing the AutomatedTests line to speed up tests) without changing anything. I suspect this could be a bug in the used JVM? Can you reproduce it locally?

[ktatavarthi]

Indeed, I can run those tests locally with a mvn clean verify from the module (removing the AutomatedTests line to speed up tests) without changing anything. I suspect this could be a bug in the used JVM? Can you reproduce it locally?

I also tried to run locally with mvn clean verify from the module (removing the AutomatedTests line to speed up tests) without changing anything. The tests fail for me locally with the below error
java.lang.NoClassDefFoundError: Lorg/apache/maven/surefire/spi/MasterProcessChannelProcessorFactory;

[mickaelistria]

FWIW, I'm using latest Java release.

[jukzi]

this PR duplicates #7 please close one of them and resolve the remaining