Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot invoke "org.eclipse.jdt.internal.compiler.lookup.TypeBinding.hasNullTypeAnnotations()" because "providedType" is null #1959

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

stephan-herrmann
Copy link
Contributor

fixes #1954

"org.eclipse.jdt.internal.compiler.lookup.TypeBinding.hasNullTypeAnnotations()"
because "providedType" is null

fixes eclipse-jdt#1954
@stephan-herrmann
Copy link
Contributor Author

@jarthana this PR could use a review by the author of #1513 because all this is totally new to me.

Somehow, you managed to implement a template expression as a message send with "unresolvable" arguments: StringTemplate only implements resolve(BlockScope) but not resolveType(BlockScope), which even causes MessageSend.argumentsHaveErrors and lots of follow-up repair attempts. I'm mostly surprised how this could ever work so far 😄

My fix-attempt may be totally off the mark, but it's simple and fixes the issue at hand 😄

Copy link
Member

@jarthana jarthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jarthana jarthana merged commit dfb3e4c into eclipse-jdt:master Feb 5, 2024
9 checks passed
@stephan-herrmann
Copy link
Contributor Author

Looks good to me.

thanks!

@stephan-herrmann stephan-herrmann deleted the issue1954 branch February 6, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants