Refactor check-header script
#1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor check header script to only consider the `endYear` in copyrigh headers. Previously we also had a mechanism in place to validate the start year of a copyright range. However, this approach was flawed because - It could not consider files that predate the initial inception of the repository - had a hard time with determining the correct start year for files that have been renamed/moved So in the end we opted for ignoring startYear validations anyways and only considered endYear errors. Therefore this PR removes the entire `startYear` validation and we only check for single year or end year violations. This makes the whole check process faster and less error prone. In addition, there was an issue with files that had multiple copyright years defined (e.g. `contribution-provider` in glsp-client). This is now fixed. In addition, align version numbers with the other GLSP projects so that the dev-packages can be included in the Release train. Also: Minor fix for `release-vscode-integration`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Refactor check header script to only consider the
endYearin copyrigh headers. Previously we also had a mechanism in place to validate the start year of a copyright range. However, this approach was flawed becauseSo in the end we opted for ignoring startYear validations anyways and only considered endYear errors. Therefore this PR removes the entire
startYearvalidation and we only check for single year or end year violations. This makes the whole check process faster and less error prone.In addition, there was an issue with files that had multiple copyright years defined (e.g.
contribution-providerin glsp-client). This is now fixed.In addition, align version numbers with the other GLSP projects so that the dev-packages can be included in the Release train.
Also: Minor fix for
release-vscode-integrationHow to test
Follow-ups
Changelog