Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1179 Switch to composite ts build #60

Merged
merged 1 commit into from Apr 15, 2024
Merged

GLSP-1179 Switch to composite ts build #60

merged 1 commit into from Apr 15, 2024

Conversation

tortmayr
Copy link
Contributor

What it does

Switch to composite ts build
Part of eclipse-glsp/glsp/issues/1179

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and I think it works. However, I noticed that previously yarn build built the following projects:

    - workflow-vscode-example
    - workflow-vscode-example-web
    - workflow-glsp-webview
    - @eclipse-glsp/vscode-integration
    - @eclipse-glsp/vscode-integration-webview

Now it is just:

    - workflow-vscode-example
    - workflow-vscode-example-web
    - workflow-glsp-webview

Is that to be expected?

@tortmayr
Copy link
Contributor Author

Code looks good to me and I think it works. However, I noticed that previously yarn build built the following projects:

    - workflow-vscode-example
    - workflow-vscode-example-web
    - workflow-glsp-webview
    - @eclipse-glsp/vscode-integration
    - @eclipse-glsp/vscode-integration-webview

Now it is just:

    - workflow-vscode-example
    - workflow-vscode-example-web
    - workflow-glsp-webview

Is that to be expected?

Yes that is expected. The output you described is from lerna when you are streaming commands
e.g: yarn lerna run clean. Since we have a composite build now we no longer use lerna run for
the tsc compilation. However, we still use it for the webpack bundle creation of the extensions:

 >  Lerna (powered by Nx)   Running target bundle for 3 projects:

    - workflow-vscode-example
    - workflow-vscode-example-web
    - workflow-glsp-webview

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I am happy with the explanation! Let's get this merged!

@tortmayr tortmayr merged commit f6a13d3 into master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants