Ensure we do not return an invalid anchor point during edge routing #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
reviewed
Mar 8, 2024
| import { injectable } from 'inversify'; | ||
|
|
||
| @injectable() | ||
| export class GLSPPolylineEdgeRouter extends PolylineEdgeRouter { |
There was a problem hiding this comment.
If I recall correctly we decided in a previous discussion regarding the naming of the feature modules to not use the GLSP prefix if possible and rather rexport the parent sprotty class with a sprotty prefix.
So we should probably change this to
Suggested change
| export class GLSPPolylineEdgeRouter extends PolylineEdgeRouter { | |
| export class PolylineEdgeRouter extends SprottyPolylineEdgeRouter { |
and add the corresponding rexport to the glsp-sprotty package
There was a problem hiding this comment.
Good point, I pushed an update that properly deals with the sprotty-fixed versions and the re-export!
martin-fleck-at
force-pushed
the
issues/1270
branch
from
310a9f5
to
002df84
Compare
tortmayr
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes eclipse-glsp/glsp#1270
Basically the problem is that the
DiamondAnchormay return an invalid point during its calculation if you give it an element which has as center the given refPoint, resulting in a 0-length PointToPointLine and ultimately to a division by zero.How to test
Follow-ups
Changelog