Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we apply feedback actions already on SetModel #322

Merged
merged 7 commits into from Mar 12, 2024
Merged

Ensure we apply feedback actions already on SetModel #322

merged 7 commits into from Mar 12, 2024

Commits on Mar 10, 2024

  1. Ensure we apply feedback actions already on SetModel 

    Fixes eclipse-glsp/glsp#1239
    @martin-fleck-at
    martin-fleck-at committed Mar 10, 2024
    Copy the full SHA
    75f12c6 View commit details
    Browse the repository at this point in the history

  2. Apply PR feedback 

    - Avoid code duplication by moving function into feedback dispatcher
    @martin-fleck-at
    martin-fleck-at committed Mar 10, 2024
    Copy the full SHA
    81b2264 View commit details
    Browse the repository at this point in the history

  3. Apply further PR feedback: Use ranked for feedback commands

    @martin-fleck-at
    martin-fleck-at committed Mar 10, 2024
    Copy the full SHA
    f361c07 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Further fixing: Avoid circular dependency with contribution provider

    @martin-fleck-at
    martin-fleck-at committed Mar 11, 2024
    Copy the full SHA
    8fa1e67 View commit details
    Browse the repository at this point in the history

  2. Apply further PR feedback 

    - Avoid unnecessary types in contribution-provider, re-use GLSP ones
- Use undefined instead of 'null'
- Export 'ContributionProvider' also as 'TYPES.IContributionProvider'
- Adapt copyright header
    @martin-fleck-at
    martin-fleck-at committed Mar 11, 2024
    Copy the full SHA
    b6c7b18 View commit details
    Browse the repository at this point in the history

  3. Do not expose 'ContributionProvider' directly

    @martin-fleck-at
    martin-fleck-at committed Mar 11, 2024
    Copy the full SHA
    4a08758 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Move 'ContributionProvider' into client package

    @martin-fleck-at
    martin-fleck-at committed Mar 12, 2024
    Copy the full SHA
    1c5f299 View commit details
    Browse the repository at this point in the history