Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up and simplify LauncherTests #566

Closed

Conversation

HannesWell
Copy link
Member

No description provided.

Copy link

Test Results

   26 files   -  2     26 suites   - 2   11m 31s ⏱️ -32s
2 170 tests ± 0  2 118 ✅  -  6  46 💤 ±0  6 ❌ +6 
2 214 runs   - 28  2 162 ✅  - 34  46 💤 ±0  6 ❌ +6 

For more details on these failures, see this check.

Results for commit f70f118. ± Comparison against base commit a90c944.

@HannesWell
Copy link
Member Author

I assume the test-failure is either due to the conversion to text-block (which uses the platform-specific line-separator instead of always \n) or maybe some charset issues due to the change in writeEclipseIni(). But I currently have don't have the nerve to investigate that.
Anyone interested, is welcome to pick this up, maybe also considering to convert this test-project into a 'regular' test fragment to get rid of the symbolic link to JNIBridge which also does not work well on windows.

@HannesWell HannesWell closed this Mar 25, 2024
@HannesWell HannesWell deleted the cleanup-LauncherTests branch March 25, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant