Enforce encapsulation of equinox-launcher Constants and JNIBridge #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like at least the org.eclipse.launcher.tests introduced with #401, needs some adjustments. |
HannesWell
force-pushed
the
equinox-launcher-encapsulation
branch
from
55c5963
to
4504ab2
Compare
tjwatson
reviewed
Mar 25, 2024
...ure/library/org.eclipse.launcher.tests/src/org/eclipse/equinox/launcher/TestLauncherApp.java
Show resolved
Hide resolved
HannesWell
force-pushed
the
equinox-launcher-encapsulation
branch
from
4504ab2
to
0b00fc8
Compare
HannesWell
force-pushed
the
equinox-launcher-encapsulation
branch
from
0b00fc8
to
d490910
Compare
Ok, good. |
tjwatson
approved these changes
Mar 26, 2024
Not from me. |
HannesWell
added a commit
to HannesWell/equinox
that referenced
this pull request
Mar 30, 2024
Because JNIBridge is a package-private class since [1] it cannot be referenced from external bundles anyway. So there is no need for API-tags to prohibit that. [1] - eclipse-equinox#565
HannesWell
added a commit
to HannesWell/equinox
that referenced
this pull request
Mar 30, 2024
Because JNIBridge is now a package-private class it cannot be referenced from other bundles anyway. So there is no need for API-tags that prohibit it. Follow-up of eclipse-equinox#565
HannesWell
added a commit
that referenced
this pull request
Mar 30, 2024
Because JNIBridge is now a package-private class it cannot be referenced from other bundles anyway. So there is no need for API-tags that prohibit it. Follow-up of #565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Eclipse SDK there are neither references to
org.eclipse.equinox.internal.launcher.Constantsnor toorg.eclipse.equinox.launcher.JNIBridge.@tjwatson or anybody else are you aware of external users that need those two classes public at the places where they are?