Clean-up and simplify LinuxPasswordProvider and WinCrypto #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
cleanup_password-providers
branch
from
55591ec
to
eb4aa67
Compare
And remove 'arch' attribute of 'o.e.equinox.security.linux' in the 'o.e.equinox.core.sdk' feature to reflect that the fragment is architecture-independent.
HannesWell
force-pushed
the
cleanup_password-providers
branch
from
eb4aa67
to
f97226b
Compare
HannesWell
commented
Mar 24, 2024
| @@ -10,5 +10,4 @@ Bundle-Localization: fragment | |||
| Eclipse-PlatformFilter: (osgi.os=linux) | |||
| Export-Package: org.eclipse.equinox.internal.security.linux;x-internal:=true | |||
| Automatic-Module-Name: org.eclipse.equinox.security.linux | |||
| Eclipse-BundleShape: dir | |||
There was a problem hiding this comment.
Adding this in fdebce6, was actually not necessary since this fragment does not contain any native code anymore.
Should apply this 'arch' removal to the |
See eclipse-equinox/p2#492 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove 'arch' attribute of 'o.e.equinox.security.linux' in the 'o.e.equinox.core.sdk' feature to reflect that the fragment is architecture-independent.