Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5427 UISelectMany collectionType ignored when VE resolves to non-Collection #5428

Merged
merged 1 commit into from Mar 30, 2024
Merged

Fix #5427 UISelectMany collectionType ignored when VE resolves to non-Collection #5428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion impl/src/main/java/com/sun/faces/renderkit/html_basic/MenuRenderer.java
View file
Open in desktop
Expand Up @@ -223,7 +223,12 @@ protected Object convertSelectManyValuesForModel(FacesContext context, UISelectM
}

if (Object.class.equals(modelType)) {
return convertSelectManyValuesForArray(context, uiSelectMany, modelType, newValues);
if (uiSelectMany.getAttributes().get("collectionType") != null) {
return convertSelectManyValuesForCollection(context, uiSelectMany, null, newValues);
}
else {
return convertSelectManyValuesForArray(context, uiSelectMany, modelType, newValues);
}
}

throw new FacesException("Target model Type is no a Collection or Array");
Expand Down