#5417: remove "optimization" when composite attribute default is literal instead of VE, this will fail when the final value itself is VE #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literal instead of VE, this will fail when the final value itself is VE
arjantijms
approved these changes
Mar 18, 2024
mnriem
reviewed
Mar 20, 2024
Theoretically not. We would otherwise have retrieved issue reports from people complaining that
That's exactly why I wanted to run TCK on this. It has passed all tests on this branch. |
mnriem
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5417
Hold on with proactively merging. I want to run TCK before merge just to ensure there are no corner cases which depend on this "optimization".TCK passed.(sorry for imports being shuffled in the code diff, I reconfigured Eclipse to treat jakarta.* the same way as javax.*)