Migrate JUnit4 to JUnit5 and EasyMock/PowerMock to Mockito #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously never invoked, so is actually activated for the first time; it however initially failed on 2 tests: 1) testAddBehavior(): the original assumption was that adding handler on unsupported behavior event would throw ISE but the impl never did this, and the javadoc also didn't say any word about this, so I adjusted the test itself 2) testGetBehaviors(): the original assumption was that getClientBehaviors() returns a mutable collection but this was not the case when no initial behaviors were added, and the javadoc also didn't say any word about this, so I adjusted the test itself
BalusC
changed the title
BalusC
changed the title
melloware
approved these changes
Mar 2, 2024
arjantijms
approved these changes
Mar 4, 2024
BalusC
added a commit
that referenced
this pull request
Mar 9, 2024
BalusC
added a commit
that referenced
this pull request
Mar 9, 2024
BalusC
added a commit
that referenced
this pull request
Mar 9, 2024
BalusC
added a commit
that referenced
this pull request
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before migration:
After migration: