Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two missing configuration for Apache - DefaultAuthSchemeRegistry … #4686

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

nddipiazza
Copy link

Add two missing configuration for Apache HTTP client properties:

builder.setDefaultAuthSchemeRegistry
builder.setRedirectStrategy

These are blockers for several use cases.

In particular, without the ability to update the default auth scheme registry, you cannot do Spnego AuthScheme.

…and RedirectStrategy

Signed-off-by: Nicholas DiPiazza <nicholas.dipiazza@lucidworks.com>
@senivam
Copy link
Contributor

senivam commented Jan 18, 2021

There is a valid ECA on file for nicholas.dipiazza@lucidworks.com. But check fails for some reason.

Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some tests for those changes?

And when editing those files, could you please modify Copyright year on top of each file to be 2021 (instead 2020 for example)? The 2nd CP year shell be modified.

@nddipiazza
Copy link
Author

@senivam I am trying to add a unit test, but the master branch will not compile. Is there some quick contributing eclipse/intellij setup guide so i can get a workspace set up?

@senivam
Copy link
Contributor

senivam commented Jan 20, 2021

@nddipiazza if you previously compiled the branch (using JDK 8 for example) and now it does not pass again you can try to remove all target/* folders and compile it again using same JDK. If this does not help it's possible to clean local .m2/repository/org/glassfish/jersey folder and build jersey again.

BTW, we have another approach of supplying parameters which are not explicitly indicated in properties to Apache connector which is manual implementing of ApacheHttpClientBuilderConfigurator SPI interface and passing all required properties via custom HttpClientBuilder configure(HttpClientBuilder httpClientBuilder); method. Please consider which approach suits better you needs - direct properties config of SPI interface extension.

@nddipiazza
Copy link
Author

Yep the .m2 repositories thing fixed it. Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants