JETUT-72 catch up servlet and faces hello world as per changes in tutorial #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvlet_and_faces_hello_world_as_per_changes_in_tutorial
mvn install it but GF7 throws error invalid user/password -- WIP
…vlet_and_faces_hello_world_as_per_changes_in_tutorial
|
@arjantijms please review |
|
@mnriem can you review? |
mnriem
requested changes
Dec 11, 2023
| @@ -162,7 +162,7 @@ | |||
| <version>3.2.3</version> | |||
| </requireMavenVersion> | |||
| <requireJavaVersion> | |||
| <version>1.8</version> | |||
| <version>[11,)</version> | |||
There was a problem hiding this comment.
Recommend pinning it against a 'certified' version.
There was a problem hiding this comment.
Not understanding. Please elaborate (with an example).
| @@ -191,8 +191,8 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <configuration> | |||
| <source>1.8</source> | |||
| <target>1.8</target> | |||
| <source>11</source> | |||
There was a problem hiding this comment.
Plugin version should be updated to latest and configuration should use 11
There was a problem hiding this comment.
Not understanding. It's already 11. Please elaborate.
|
thanks @mnriem! |
|
@kito99 Do you need more from my end? |
…aces_hello_world_as_per_changes_in_tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.