JETUT-112 Add example for the Custom form authentication mechanism #79
Conversation
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
| </p> | ||
|
|
||
| <form faces:id="form"> | ||
| <p> |
There was a problem hiding this comment.
These should be <div> elements or a semantic elements. (For example, the login could be a <header>: https://github.com/virtua-tech/jakartaee-tutorial/blob/main/STYLE_GUIDE.adoc#use-of-etc-eg-and-ie.
should be reserved for actual paragraphs in text.
| > | ||
| <h:head/> | ||
|
|
||
| <h:messages /> |
| --> | ||
|
|
||
| <html lang="en" | ||
| xmlns="http://www.w3.org/1999/xhtml" |
There was a problem hiding this comment.
This is optional since Faces 4 (at least, it won't anymore emit a Facelets compiler warning when HTML5 doctype is used), you can remove it for brevity.
|
|
||
| <h:messages /> | ||
|
|
||
| <body> |
There was a problem hiding this comment.
Should be h:body for consistency (and to avoid future confusion when developer decides to extend based on the very example snippet).
| Login to continue | ||
| </p> | ||
|
|
||
| <form faces:id="form"> |
There was a problem hiding this comment.
That will work but I'm wondering why this example explicitly uses passthrough elements instead of plain components? Heritage of a snippet specifically geared for j_security_check?
There was a problem hiding this comment.
why this example explicitly uses passthrough elements instead
I think there's no specific reason. Throw of a coin to decide between passthrough and regular I guess.
No description provided.