ssl: introduce SSLEngineConfigurator#setSSLParameters #2054
Conversation
There was a problem hiding this comment.
I suppose this is fine, although it's interesting that SSLParameters supports a lot of
options that are ignored here, and SSLEngine can take an SSLParamaters object
directly, but that isn't done here. I suspect this code should be updated to handle
additions to SSLEngine in JDK 1.7 and 1.8.
|
As mentioned in the commit message, this can be the first step. The SSLEngineConfigurator can be updated to build SSLParamaters and then use it when SSLEngineConfigurator#configure method is called. This will make code much simple. |
| @@ -272,6 +273,21 @@ public SSLEngineConfigurator setWantClientAuth(boolean wantClientAuth) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Apply {@link SSLParameters} to this SSLEngineConfigurator. | |||
There was a problem hiding this comment.
Apply {@link SSLParameters} to this SSLEngineConfigurator.
Might want to document that only the cipherSuites, protocols, needClientAuth and wantClientAuth properties are applied?
|
may be make sense to squash this two commits... |
|
@kofemann Have you applied the requested changes? |
|
Are people interested in this changes? In general, looks like grizzly project has very low activity since eclipse took over. |
We definitely have a low amount of resources to work on Grizzly, which is really unfortunate :( |
|
Ok. Let me rebase and retest. I will update the PR. |
SSLParameters is a class introduced in java6 which can take over SSLEngineConfigurator. As a first step, let allow applications to use SSLParameters to configure SSLEngineConfigurator. Update SSLEngineConfigurator to use it internally instead of bunch of class fields. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
|
@arjantijms Looks good to me |
SSLParameters is a class introduced in java6 which can take over
SSLEngineConfigurator. As a first step, let allow applications to
use SSLParameters to configure SSLEngineConfigurator.