New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue 24868 Clean code: fix unlikely argument and remove some unused variables. #24870
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,21 +17,13 @@ | |
|
||
package com.sun.enterprise.resource.deployer; | ||
|
||
import com.sun.appserv.connectors.internal.api.ConnectorConstants; | ||
import com.sun.enterprise.config.serverbeans.Resource; | ||
import com.sun.enterprise.config.serverbeans.Resources; | ||
import com.sun.enterprise.deployment.JMSDestinationDefinitionDescriptor; | ||
import com.sun.logging.LogDomains; | ||
|
||
import jakarta.inject.Inject; | ||
import jakarta.inject.Provider; | ||
import static com.sun.appserv.connectors.internal.api.ConnectorsUtil.deriveResourceName; | ||
|
||
import java.beans.PropertyVetoException; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
import java.util.Map.Entry; | ||
import java.util.Properties; | ||
import java.util.logging.Logger; | ||
|
||
import org.glassfish.api.naming.SimpleJndiName; | ||
import org.glassfish.connectors.config.AdminObjectResource; | ||
|
@@ -43,7 +35,13 @@ | |
import org.jvnet.hk2.config.TransactionFailure; | ||
import org.jvnet.hk2.config.types.Property; | ||
|
||
import static com.sun.appserv.connectors.internal.api.ConnectorsUtil.deriveResourceName; | ||
import com.sun.appserv.connectors.internal.api.ConnectorConstants; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Imports should be ordered by alphabet. Static imports should be first or last, but together, that is ok. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry I assumed the ee4j Eclipse formatter took care of the order. I will minimise import statement changes in the future. |
||
import com.sun.enterprise.config.serverbeans.Resource; | ||
import com.sun.enterprise.config.serverbeans.Resources; | ||
import com.sun.enterprise.deployment.JMSDestinationDefinitionDescriptor; | ||
|
||
import jakarta.inject.Inject; | ||
import jakarta.inject.Provider; | ||
|
||
@Service | ||
@ResourceDeployerInfo(JMSDestinationDefinitionDescriptor.class) | ||
|
@@ -52,7 +50,6 @@ public class JMSDestinationDefinitionDeployer implements ResourceDeployer<JMSDes | |
@Inject | ||
private Provider<org.glassfish.resourcebase.resources.util.ResourceManagerFactory> resourceManagerFactoryProvider; | ||
|
||
private static final Logger LOG = LogDomains.getLogger(JMSDestinationDefinitionDeployer.class, LogDomains.RSR_LOGGER); | ||
static final String PROPERTY_PREFIX = "org.glassfish.jms-destination."; | ||
|
||
@Override | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, good catch!