Fixes issue #24843 log a warning in the rare case the Resource handle #24844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource handle state is not busy instead of throwing an exception
dmatej
approved these changes
Mar 6, 2024
|
I don't like making private fields protected just for unit tests, but I still think that this fix is more important :) |
dmatej
reviewed
Mar 6, 2024
...ectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Outdated
Show resolved
Hide resolved
…StateException" commented out code.
dmatej
approved these changes
Mar 7, 2024
avpinchuk
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24843 log a warning in the rare case the Resource handle
Created a unit test to test the ConnectionPool code.
Perhaps there is another way to set the private processEnvironment in the ConnectorRuntime class.
Perhaps the message should not be a WARNING, but since no one else logged it I do not think it would harm.