Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Integer Overflow in Calculation of Virtual Thread Queue Size #80

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Mar 4, 2024

Very often, the queue size is configured high, e.g. Integer.MAX_VALUE. So addition with maximal parallelization it overflows. This PR checks it and sets MAX_VALUE.

Plus a minor improvement in error log, displaying available number of threads to start (it should be zero if everything works well).

@arjantijms arjantijms merged commit 3703216 into eclipse-ee4j:master Mar 4, 2024
1 check passed
@aubi aubi deleted the virtualthreads-fix-int-overflow-queue-size branch March 8, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants