Throw exception in managed task so that it has to be handled or logged. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid that the exception is swallowed in case there's no ManagedTask listener. Also add the original exception as the cause to add it to the stacktrace. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
arjantijms
approved these changes
Mar 4, 2024
|
Just an idea - wouldn't be better it would be some custom exception instead of generic RuntimeException? Or is it worthless in this case? |
|
Everything can be improved. I just focused on throwing an exception that would be swallowed otherwise. It probably doesn't happen often, it only happened to me when I was implementing executors in Concurro using virtual threads when I had a bug there. If it would be something that can regularly happen, then it would deserve a custom exception but have no evidence of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid that the exception is swallowed in case there's no ManagedTask listener.
Also add the original exception as the cause to add it to the stacktrace.