support of mariadb sequences fixes #883 #965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vjacheslav Borisov <slavb@ilb.ru>
|
SEQUENCES supported only on mariadb 10.3+, tests fails May be there should be mysql server version check in method |
rfelcman
requested changes
Jan 15, 2021
There was a problem hiding this comment.
Sorry but it seems, that this PR break compatibility with older MySQL versions (5.6, 5.7). See PR checks (Travis-CI output)
I see there possible solutions:
- Add to EclipseLink new platform e.g.
org.eclipse.persistence.platform.database.MariaDBand inherit and override content fromorg.eclipse.persistence.platform.database.MySQLPlatform - Check DB server version in origin
org.eclipse.persistence.platform.database.MySQLPlatformsee e.g. https://github.com/eclipse-ee4j/eclipselink/blob/master/foundation/org.eclipse.persistence.core/src/main/java/org/eclipse/persistence/platform/database/SQLServerPlatform.java#L79 and put Your changes in conditions, but as I checked some changes are similar like inherited fromorg.eclipse.persistence.internal.databaseaccess.DatabasePlatform#buildSequenceObjectDeletionWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of mariadb sequences
https://mariadb.com/kb/en/sequences/