[master] Bug 551815: When an entity with an aggregate with all fields set to null is changed to null for the aggregate field then Eclipselink executes a bogus no-op SQL update statement #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set to null is changed to null for the aggregate field then Eclipselink executes a bogus no-op SQL update statement Signed-off-by: Eduardo Perez Ureta <edpeur@gmail.com>
dazey3
reviewed
Sep 17, 2019
| return true; | ||
| } | ||
| final Set<java.lang.reflect.Field> fields = getAllFields(new HashSet<java.lang.reflect.Field>(), o.getClass()); | ||
| for (final java.lang.reflect.Field f : fields) { |
There was a problem hiding this comment.
If Object o is not null and contains no fields, then return true?
There was a problem hiding this comment.
Yes, that is intended as there should not be any difference. Do you see any problem in that behavior?
dazey3
reviewed
Sep 17, 2019
...ipselink.core.test/src/org/eclipse/persistence/testing/models/aggregate/SimpleAggregate.java
Show resolved
Hide resolved
dazey3
reviewed
Sep 17, 2019
...k.core.test/src/org/eclipse/persistence/testing/models/aggregate/SimpleAggregateProject.java
Show resolved
Hide resolved
eperez
force-pushed
the
bugfix/simple-aggregate-null
branch
from
380cbb3
to
5c56125
Compare
|
How does this deal with fields marked '@transient'? What if app uses annotations on methods and not on fields? ie eclipselink can trigger getter which in turn returns something different from what is stored in the field.. |
lukasj
requested changes
Sep 18, 2019
eperez
force-pushed
the
bugfix/simple-aggregate-null
branch
from
5c56125
to
0feb9cb
Compare
@lukasj I have changed the code to use ObjectBuilder instead. Is it OK now? |
eperez
force-pushed
the
bugfix/simple-aggregate-null
branch
from
0feb9cb
to
fc72bd2
Compare
eperez
force-pushed
the
bugfix/simple-aggregate-null
branch
from
fc72bd2
to
194db07
Compare
eperez
changed the title
eperez
force-pushed
the
bugfix/simple-aggregate-null
branch
from
194db07
to
0addc8c
Compare
|
Could You please fix year in the copyright header:
same case for #606 |
eperez
force-pushed
the
bugfix/simple-aggregate-null
branch
2 times, most recently
from
c7d2d4c
to
a407560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.