Fixes to make 0.10.x branch pass tests on Ubuntu 24.04 #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial backport of eclipse-cyclonedds#1947 Signed-off-by: Chris Lalancette <clalancette@gmail.com>
If the number being formatted is near the maximum length for a 64-bit number in decimal representation, then indeed the format string would be too small -- but by construction the numbers are never that big. Still, enlarging the buffer so the warning goes away is the more elegant solution. Signed-off-by: Erik Boasson <eb@ilities.com>
…ds#1817) * ddsi_config: Fix buffer overflow for snprintf under GCC 12.3.0 * ddsi_config: Update generated files
eboasson
merged commit f2ec524
into
eclipse-cyclonedds:releases/0.10.x
12 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out CycloneDDS on Ubuntu 24.04, I found that some of the tests failed; see #1959 for more details.
This PR fixes those tests. It is a combination of three fixes:
-DCMAKE_BUILD_TYPE=Debug, gcc 13.2.0 was complaining about an overrun of a buffer, and this fixes that.snprintfbuffer overflow under GCC 12.3.0 #1817 , which fixes the actual crashes. Because this needs some generated code, I followed the instructions in Failing tests on the releases/0.10.x on Ubuntu 24.04 #1959 (comment) to actually complete the backport here.This should fix #1959