Always make idlc_generate available in install #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cross-builds, and now therefore also static builds, one does need IDLC. Installing Generate.cmake unconditionally means one can always write idlc_generate(TARGET konijn FILES wortel.idl) and one only has to make sure that CMake can find "idlc" and the backend library. Adding the host build to the CMAKE_PREFIX_PATH as in: cmake -DCMAKE_PREFIX_PATH=.../target-install\;.../host-install results in CMake finding the CycloneDDS package for the target in the target-install directory while also looking (and finding) idlc and the backend somewhere in the host-install directory. Signed-off-by: Erik Boasson <eb@ilities.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cross-builds, and now therefore also static builds, one does need IDLC. Installing Generate.cmake unconditionally means one can always write
idlc_generate(TARGET konijn FILES wortel.idl)
and one only has to make sure that CMake can find "idlc" and the backend library. Adding the host build to the CMAKE_PREFIX_PATH as in:
cmake -DCMAKE_PREFIX_PATH=.../target-install;.../host-install
results in CMake finding the CycloneDDS package for the target in the target-install directory while also looking (and finding) idlc and the backend somewhere in the host-install directory.