Add build-time option for TCP+TLS support #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
force-pushed
the
make-tcp-tls-configurable
branch
2 times, most recently
from
cccd15d
to
93b632a
Compare
ENABLE_SSL did two things: * Enable the built-in plugins (if ENABLE_SECURITY) * Enable TCP+TLS support TCP support is rarely used and has some problems, TCP+TLS support is even more rarely used and we recommend using DDS Security instead. If TCP+TLS is not recommended, it makes sense to support builds that leave it out. This also has the advantage of being able to include support for DDS Security with the built-in plugins but without introducing a dependency on OpenSSL for the core library. Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
force-pushed
the
make-tcp-tls-configurable
branch
from
93b632a
to
896daa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_SSL did two things:
TCP support is rarely used and has some problems, TCP+TLS support is even more rarely used
and we recommend using DDS Security instead. If TCP+TLS is not recommended, it makes sense
to support builds that leave it out. This also has the advantage of being able to
include support for DDS Security with the built-in plugins but without introducing a
dependency on OpenSSL for the core library.