Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor odds-and-ends #1950

Merged
merged 5 commits into from Mar 27, 2024
Merged

Minor odds-and-ends #1950

merged 5 commits into from Mar 27, 2024

Conversation

eboasson
Copy link
Contributor

@eboasson eboasson commented Mar 22, 2024 •
edited

This combines various things I had lying around on my disk for quite some time and that I believe are worthy of inclusion:

  • Additional non-null/warn-unused-result attributes for various functions related to submessage construction — it doesn't fix any problem, but it does serve as a form of documentation and sometimes helps catch issues earlier.
  • Removal of the UnicastResponseToSPDPMessages option: a weird option where both common sense and documentation agree that "there is no known benefit to it". Perhaps it is time to delete it.
  • Dumping of the full contents of malformed packets to the trace, with an option available to also get them dumped on stderr.
  • Support for optional members in the dynsub example (I had to test something and adding support was the path of least resistance 🙂)

@eboasson
Add non-null, &c attributes to xmsg.h
ae70ba1 
Signed-off-by: Erik Boasson <eb@ilities.com>
@eboasson
Delete UnicastResponseToSPDPMessages option
cf0f755 
This was a bit of weird option with both common sense and the
documentation agreeing that "there is no known benefit to setting this
to false".

Deleting altogether therefore seems more sensible then marking it
deprecated and ignoring it.

Signed-off-by: Erik Boasson <eb@ilities.com>
@eboasson
Dump malformed packets to trace, optionally to log
1c5b2a5 
Signed-off-by: Erik Boasson <eb@ilities.com>
@eboasson
Add support for optional members in dynsub
3c6e53e 
Signed-off-by: Erik Boasson <eb@ilities.com>
@eboasson
Fix race condition in security FSM unit test
ec92706 
Signed-off-by: Erik Boasson <eb@ilities.com>
@eboasson eboasson merged commit 0118042 into eclipse-cyclonedds:master Mar 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpotman dpotman dpotman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eboasson @dpotman