Fix subscriber's chunk leak in shm_monitor when unknown chunk type is retrieved from iceoryx #1941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes a memory leak in shm_monitor in release/0.10.4 in the receive_data_wakeup_handler function.
Typical flow in this function is:
However in some cases if chunk type is not recognized it is not wrapped into ddsi_serdata strcture and currently it is never released. This MR fixes this execution path.
This seems to fix ros2/rmw_cyclonedds#471 for me.