Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_cdr and take_cdr #481

Merged
merged 3 commits into from Apr 4, 2024

Conversation

eboasson
Copy link
Contributor

@eboasson eboasson commented Apr 4, 2024

... and incidentally address the

/home/vsts/work/1/s/src/ddscxx/include/dds/sub/detail/SamplesHolder.hpp:89:9: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
        ddsi_serdata_to_ser_ref(sd, 0, ddsi_serdata_size(sd), &blob_content);
        ^~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

flagged by the CI in #480 but not caused by it. (It was caused by eclipse-cyclonedds/cyclonedds#1947 adding the warn_unused_result attribute, and that's a good thing as it helped catch the bugs and the missing test.)

Signed-off-by: Erik Boasson <eb@ilities.com>
They returned only ever Empty CDR blobs because the blob kind wasn't getting set.

Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
@eboasson eboasson merged commit 4f26cb4 into eclipse-cyclonedds:master Apr 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants