Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'remove ruleset' button on preference page #466

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

marvinvo
Copy link

Description

This changes will add a "remove selected ruleset" button to the preference page.

Bildschirmfoto 2022-02-18 um 10 42 36

Fixes #464

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Eclipse Version:
  • Java Version:
  • OS:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
    • eclipse preference recorder is listening to changes on rulesets and will notify the developer on saved changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marvinvo marvinvo marked this pull request as draft February 18, 2022 09:54
@marvinvo marvinvo marked this pull request as ready for review February 18, 2022 09:54
@marvinvo marvinvo closed this Mar 14, 2022
@marvinvo marvinvo reopened this Mar 14, 2022
@marvinvo marvinvo closed this Jun 20, 2022
@marvinvo marvinvo reopened this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No delete button for custom rules
1 participant