Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding a note with UBI recommendation / Devfile.io #2727

Merged
merged 6 commits into from May 9, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Apr 25, 2024

Screenshot 2024-04-25 at 15 08 17

What does this pull request change?

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested review from deerskindoll and a team as code owners April 25, 2024 13:05
@ibuziuk ibuziuk requested a review from nickboldt April 25, 2024 13:05
Copy link

github-actions bot commented Apr 25, 2024

🎊 Navigate the preview: https://663e0c17a84fe203da0fdca8--eclipse-che-docs-pr.netlify.app 🎊

@che-bot che-bot added this to Triage in Reviews Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

Click here to review and test in web IDE: Contribute

Reviews automation moved this from Triage to Approved Apr 25, 2024
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk changed the title feat: Adding a note with UBI recommendation feat: Adding a note with UBI recommendation / Devfile.io Apr 25, 2024
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk
Copy link
Member Author

ibuziuk commented May 9, 2024

@RomanNikitenko PR has been updated please review

@ibuziuk
Copy link
Member Author

ibuziuk commented May 9, 2024

@deerskindoll could you please merge?

@deerskindoll deerskindoll merged commit e1e13ce into eclipse-che:main May 9, 2024
5 of 6 checks passed
Reviews automation moved this from Approved to Done May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Reviews
  
Done
4 participants