Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update devfile.yaml #2700

Merged
merged 1 commit into from Mar 7, 2024
Merged

chore: Update devfile.yaml #2700

merged 1 commit into from Mar 7, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Mar 6, 2024

What does this pull request change?

What issues does this pull request fix or reference?

eclipse-che/che#22864

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@ibuziuk ibuziuk requested review from deerskindoll and a team as code owners March 6, 2024 14:23
@ibuziuk ibuziuk requested a review from nickboldt March 6, 2024 14:23
Copy link

github-actions bot commented Mar 6, 2024

🎊 Navigate the preview: https://65e87d81ac098a0081f2abc4--eclipse-che-docs-pr.netlify.app 🎊

@che-bot che-bot added this to Triage in Reviews Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Reviews automation moved this from Triage to Approved Mar 6, 2024
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 6, 2024

@deerskindoll could you please follow up on PR check failure?

@ibuziuk ibuziuk requested a review from dkwon17 March 6, 2024 15:50
Copy link
Contributor

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working for me now

@ibuziuk ibuziuk merged commit 9c78e14 into main Mar 7, 2024
11 of 12 checks passed
@ibuziuk ibuziuk deleted the ibuziuk-patch-2 branch March 7, 2024 13:54
Reviews automation moved this from Approved to Done Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Reviews
  
Done
3 participants