Editor Selector improvements #1079
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1079 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1079", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 89.15% 89.17% +0.01%
==========================================
Files 397 398 +1
Lines 40580 40664 +84
Branches 2735 2740 +5
==========================================
+ Hits 36178 36261 +83
- Misses 4376 4377 +1
Partials 26 26 ☔ View full report in Codecov by Sentry. |
|
Verified on Eclipse Che with |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.13 :: dashboard_3.x/470: Console, Changes, Git Data |
|
Build 3.13 :: dashboard_3.x/471: Console, Changes, Git Data |
|
Build 3.13 :: sync-to-downstream_3.x/6399: Console, Changes, Git Data |
|
Build 3.13 :: sync-to-downstream_3.x/6400: Console, Changes, Git Data |
|
Build 3.13 :: push-latest-container-to-quay_3.x/4504: Console, Changes, Git Data |
|
Build 3.13 :: get-sources-rhpkg-container-build_3.x/6361: dashboard : 3.x :: Build 60251686 : quay.io/devspaces/dashboard-rhel8:3.13-18 |
|
Build 3.13 :: update-digests_3.x/6245: Console, Changes, Git Data |
|
Build 3.13 :: dashboard_3.x/470: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6399 triggered |
|
Build 3.13 :: operator-bundle_3.x/2731: Console, Changes, Git Data |
|
Build 3.13 :: sync-to-downstream_3.x/6401: Console, Changes, Git Data |
|
Build 3.13 :: push-latest-container-to-quay_3.x/4505: Console, Changes, Git Data |
|
Build 3.13 :: push-latest-container-to-quay_3.x/4506: Console, Changes, Git Data |
|
Build 3.13 :: get-sources-rhpkg-container-build_3.x/6362: dashboard : 3.x :: Build 60251763 : quay.io/devspaces/dashboard-rhel8:3.13-19 |
|
Build 3.13 :: dashboard_3.x/471: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6400 triggered |
|
Build 3.13 :: copyIIBsToQuay/2599: Console, Changes, Git Data |
|
Build 3.13 :: sync-to-downstream_3.x/6401: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6363 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.13 :: operator-bundle_3.x/2731: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6401 triggered |
|
Build 3.13 :: update-digests_3.x/6245: Detected new images: rebuild operator-bundle |
|
Build 3.13 :: update-digests_3.x/6246: Console, Changes, Git Data |
|
Build 3.13 :: dsc_3.x/1882: Console, Changes, Git Data |
|
Build 3.13 :: update-digests_3.x/6246: No new images detected: nothing to do! |
|
Build 3.13 :: dsc_3.x/1882: 3.13.0-CI |
What does this PR do?
This PR improves the default behavior of the Create Workspace page, so now it initially enables the "default editor" flow when creating a new workspace. That means that if a user provides only a Git repo URL and clicks "Create&Open" then the dashboard will look into the repo for a custom editor, and if it does not find one, it will apply a default editor defined at the CR level.
Another improvement is showing "Tech Preview" labels propagated with some editors.
What issues does this PR fix or reference?
Fixes eclipse-che/che#22879