Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose experiment/trace back-end resources when closing an experiment from the UI #1024

Open
bhufmann opened this issue Sep 26, 2023 · 0 comments · May be fixed by #1033
Open

Dispose experiment/trace back-end resources when closing an experiment from the UI #1024

bhufmann opened this issue Sep 26, 2023 · 0 comments · May be fixed by #1033
Labels
enhancement New feature or request trace server protocol Needs changes to the trace-server-protocol itself Trace Server Involve changes in the trace server itself (in the incubator source code)

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Sep 26, 2023 •
edited

The TSP allows to open traces and experiments on the server back-end. However, there is now dedicated request available to dispose the back-end resources related to experiments and traces in the back-end. There should be a TSP request to trigger the disposal of resources in the back-end when the front-end close the experiment.

Consider the following API:
PUT /experiments/{expUUID}:close

Consider other alternatives before implement this API.
@bhufmann bhufmann added enhancement New feature or request Trace Server Involve changes in the trace server itself (in the incubator source code) trace server protocol Needs changes to the trace-server-protocol itself labels Sep 26, 2023
@bhufmann bhufmann changed the title Close experiment and trace resources when closing an experiment Close experiment and trace resources when closing an experiment from the UI Sep 26, 2023
@bhufmann bhufmann changed the title Close experiment and trace resources when closing an experiment from the UI Close experiment/trace back-end resources when closing an experiment from the UI Sep 26, 2023
@bhufmann bhufmann changed the title Close experiment/trace back-end resources when closing an experiment from the UI Dispose experiment/trace back-end resources when closing an experiment from the UI Sep 26, 2023
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Nov 2, 2023
@bhufmann
Call TSP endpoint to close an experiment when closing it in the UI
f7e6c49 
With this it's possible to close an experiment on the server. Upon
reception of the command the server can dispose allocated resources
hence the client doesn't need them anymore.

This change follows the TSP update provided by:
eclipse-cdt-cloud/trace-server-protocol#95

Fixes eclipse-cdt-cloud#1024

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@bhufmann bhufmann linked a pull request Nov 2, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request trace server protocol Needs changes to the trace-server-protocol itself Trace Server Involve changes in the trace server itself (in the incubator source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call TSP endpoint to close an experiment when closing it in the UI bhufmann/theia-trace-extension
1 participant
@bhufmann