Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the RCP product #1606

Merged
merged 1 commit into from Mar 25, 2024
Merged

Conversation

merks
Copy link
Contributor

@merks merks commented Mar 25, 2024

Remove other unused build infrastructure:

  • birt-integration-test
  • birt-publish

Remove other unused build infrastructure:

- birt-integration-test
- birt-publish
@merks
Copy link
Contributor Author

merks commented Mar 25, 2024

@speckyspooky

The RCP product does not work well and I can see no good reason to maintain it. It's only slightly smaller than the all-in-one package:

image

Given @wimjongman already expressed is doubt about it's value and utility, removing it seems like a good idea...

Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merks merks requested a review from speckyspooky March 25, 2024 16:47
Copy link
Contributor

@speckyspooky speckyspooky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it.

@merks merks merged commit 1ea24f6 into eclipse-birt:master Mar 25, 2024
3 checks passed
@merks merks deleted the pr-remove-rcp-product branch March 25, 2024 19:00
@merks merks self-assigned this Mar 25, 2024
@speckyspooky speckyspooky added this to the 4.15 milestone Mar 25, 2024
@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Mar 25, 2024
@hvbtup
Copy link
Contributor

hvbtup commented Apr 2, 2024

+1 for removing.
I never used the RCP designer and always teached using the All-in-One designer.

There's only one aspect for which RCP designer is superior compared to the All-in-One: Simplicity.
The All-In-One IDE intimidates newcomers, because it is overloaded with a lot of things that BIRT report designers actually do not need. But most of that comes in the form of of the icon bar and the menus, so after a few hours/days when newcomers desparately look for the whatsitsname menu, they learn where it is and to ignore all the superfluous menu entries.

Most of the superfluous menu entries etc are probably there because the original developers thought that BIRT developers are Java developers at the same time (which is seldom true from my experience), and so they thought that the BIRT IDE should be a Java IDE at the same time.
It would be great if there was an optional IDE "setup" (or whatever its called) that removes all this Java related stuff from the UI, leaving only what's necessary for BIRT and Javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants