Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[Core] Fixed wrong order of widgets after sitemap changes #5523

Merged
merged 3 commits into from May 3, 2018
Merged

[Core] Fixed wrong order of widgets after sitemap changes #5523

merged 3 commits into from May 3, 2018

Commits on May 2, 2018

  1. refresh internal widget collection on sitemap change 

    This partially reverts eclipse-archived#3846.

fixes eclipse-archived#5522
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
    @sjsf
    sjsf committed May 2, 2018
    Copy the full SHA
    0b03add View commit details
    Browse the repository at this point in the history

  2. untangle model update notifiaction order 

    The SitemapSubscriptionService now gets informed by the SitemapProvider
about a model change.

Before, it was a matter of luck if the SitemapSubscriptionService or the
SitemapProvider got informed first about a model change by the
ModelRepository. If the SitemapSubscriptionService was so unlucky to be
the first one, it got a stale model from the SitemapProvider and hence
it again the calculation of the widget IDs was wrong.

Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
    @sjsf
    sjsf committed May 2, 2018
    Copy the full SHA
    0a46773 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2018

  1. removed public modifiers from SitemapProvider interface 

    Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
    @sjsf
    sjsf committed May 3, 2018
    Copy the full SHA
    19a6525 View commit details
    Browse the repository at this point in the history