Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Updated README with skipTests flag #4150

Merged
merged 1 commit into from Aug 31, 2017

Conversation

kubawolanin
Copy link
Contributor

Thanks @kaikreuzer for the info! :-)

Signed-off-by: Kuba Wolanin hi@kubawolanin.com (github: kubawolanin)

Thanks @kaikreuzer for [the info](eclipse-archived#4148 (comment))! :-)

Signed-off-by: Kuba Wolanin <hi@kubawolanin.com> (github: kubawolanin)
Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a well known fact for any Maven user, but ok ;-)

Copy link
Contributor

@maggu2810 maggu2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me.
The better suggestion would be to open an issue and later a PR with a fix. 😉

@maggu2810
Copy link
Contributor

Doesn't we require a Signed-off-line that fits to the guidelines? (correct braces and without github name)?

@kaikreuzer
Copy link
Contributor

I'll correct the syntax when squashing - I think the formal sign-off requirement is fulfilled.

@kaikreuzer kaikreuzer merged commit 3e77c4d into eclipse-archived:master Aug 31, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants