This repository has been archived by the owner on May 7, 2020. It is now read-only.
PaperUI: rework bindings list view & binding detail view #3782
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
extensions/ui/org.eclipse.smarthome.ui.paper/tests/configuration.binding.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| describe('module PaperUI.controllers.configuration.bindings', function() { | ||
| beforeEach(function() { | ||
| module('PaperUI'); | ||
| }); | ||
| describe('tests for BindingController', function() { | ||
| var bindingController, scope, mdDialog; | ||
| beforeEach(inject(function($injector, $rootScope, $controller, $mdDialog) { | ||
| scope = $rootScope.$new(); | ||
| mdDialog = $mdDialog | ||
| $controller('BodyController', { | ||
| '$scope' : scope | ||
| }); | ||
| bindingController = $controller('BindingController', { | ||
| '$scope' : scope | ||
| }); | ||
| })); | ||
| it('should require BindingController', function() { | ||
| expect(bindingController).toBeDefined(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('tests for ConfigureBindingDialogController', function() { | ||
| var configureBindingDialogController, scope, bindingService; | ||
| var restConfig; | ||
| beforeEach(inject(function($injector, $rootScope, $controller) { | ||
| scope = $rootScope.$new(); | ||
| var bindingRepository = $injector.get('bindingRepository'); | ||
| restConfig = $injector.get('restConfig'); | ||
| $rootScope.data.bindings = [ { | ||
| id : 'B' | ||
| } ]; | ||
| configureBindingDialogController = $controller('ConfigureBindingDialogController', { | ||
| '$scope' : scope, | ||
| 'binding' : { | ||
| 'id' : 'B', | ||
| 'configDescriptionURI' : 'CDURI' | ||
| }, | ||
| 'bindingRepository' : bindingRepository | ||
| }); | ||
| $httpBackend = $injector.get('$httpBackend'); | ||
| $httpBackend.when('GET', restConfig.restPath + "/config-descriptions/CDURI").respond({ | ||
| parameters : [ { | ||
| type : 'input', | ||
| name : 'PNAME' | ||
| } ] | ||
| }); | ||
| $httpBackend.when('GET', restConfig.restPath + "/bindings/B/config").respond({ | ||
| PNAME : '1' | ||
| }); | ||
| $httpBackend.flush(); | ||
| bindingService = $injector.get('bindingService'); | ||
| })); | ||
| it('should require ConfigureBindingDialogController', function() { | ||
| expect(configureBindingDialogController).toBeDefined(); | ||
| }); | ||
| it('should get binding parameters', function() { | ||
| expect(scope.parameters.length).toEqual(1); | ||
| }); | ||
| it('should get binding configuration', function() { | ||
| expect(scope.configuration.PNAME).toEqual(1); | ||
| }); | ||
| it('should add binding parameter', function() { | ||
| scope.configArray = []; | ||
| scope.addParameter(); | ||
| expect(scope.configArray.length).toEqual(1); | ||
| }); | ||
| it('should save binding configuration', function() { | ||
| spyOn(bindingService, 'updateConfig'); | ||
| scope.save(); | ||
| expect(bindingService.updateConfig).toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that for stuff that we package we have to stick to the exact version, only for build&test dependencies like gulp we can go higher.