Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things file #3772

Merged
merged 1 commit into from Jun 30, 2017
Merged

LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things file #3772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 9 additions & 10 deletions extensions/binding/org.eclipse.smarthome.binding.lifx/ESH-INF/config/config.xml
View file
Open in desktop
Expand Up @@ -4,22 +4,21 @@
xsi:schemaLocation="http://eclipse.org/smarthome/schemas/config-description/v1.0.0 http://eclipse.org/smarthome/schemas/config-description-1.0.0.xsd">

<config-description uri="thing-type:lifx:light">
<parameter name="deviceId" type="text" required="true">
<label>LIFX device ID</label>
</parameter>
<parameter name="fadetime" type="integer" required="false">
<label>Fade time</label>
<description>The time to fade to the new color value (in ms).</description>
<default>300</default>
</parameter>
<parameter name="deviceId" type="text" required="true">
<label>LIFX device ID</label>
</parameter>
<parameter name="fadetime" type="integer" required="false">
<label>Fade time</label>
<description>The time to fade to the new color value (in ms).</description>
<default>300</default>
</parameter>
</config-description>

<config-description uri="channel-type:lifx:brightness">
<parameter name="powerOnBrightness" type="integer" min="0" max="100" required="false" unit="%">
<label>Power on brightness</label>
<description>Brightness level used when switching on the light. Use empty value to leave brightness as is.</description>
<default>100</default>
</parameter>
</parameter>
</config-description>

</config-description:config-descriptions>
9 changes: 3 additions & 6 deletions extensions/binding/org.eclipse.smarthome.binding.lifx/README.md
View file
Open in desktop
Expand Up @@ -90,14 +90,11 @@ Or create items for each type (*Color*, *Switch*, *Dimmer*) and define the corre
### demo.things:

```
Thing lifx:colorlight:living [ deviceId="D073D5A1A1A1" ] {
Channels:
Type color : color [ powerOnBrightness= ]
}
Thing lifx:colorlight:living [ deviceId="D073D5A1A1A1" ]
Thing lifx:colorlight:living2 [ deviceId="D073D5A2A2A2" ] {
Channels:
Type color : color [ powerOnBrightness= ]
Type color : color [ powerOnBrightness=50 ]
}
Thing lifx:colorirlight:porch [ deviceId="D073D5B2B2B2", fadetime=0 ] {
Expand Down Expand Up @@ -135,7 +132,7 @@ Dimmer Ceiling_Temperature { channel="lifx:colormzlight:ceiling:temperature" }
Color Ceiling_Color_Zone_0 { channel="lifx:colormzlight:ceiling:colorzone0" }
Dimmer Ceiling_Temperature_Zone_0 { channel="lifx:colormzlight:ceiling:temperaturezone0" }
Color Ceiling_Color_Zone_15 { channel="lifx:colormzlight:ceiling:colorzone15" }
Dimmer Ceiling_Temperature_Zone_15 { channel="lifx:colormzlight:ceiling:colorzone15" }
Dimmer Ceiling_Temperature_Zone_15 { channel="lifx:colormzlight:ceiling:temperaturezone15" }
// Kitchen
Switch Kitchen_Toggle { channel="lifx:whitelight:kichen:brightness" }
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/org/eclipse/smarthome/binding/lifx/internal/LifxLightPropertiesUpdater.java
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@

/**
* The {@link LifxLightPropertiesUpdater} updates the light properties when a light goes online. When packets get lost
* the requests are resend when the {@code UPDATE_INTERVAL} elapses.
* the requests are resent when the {@code UPDATE_INTERVAL} elapses.
*
* @author Wouter Born - Update light properties when online
*/
Expand Down