This repository has been archived by the owner on May 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds adds the following Thing properties to LIFX lights:
All properties (except for zones) are added during discovery. Apparently new property values from discovery results are not updated. E.g. when you would manually update the firmware via the LIFX app. Also these properties are not added to Things that already exist. I've submitted issue #3323 for this.
Furthermore I've removed the StateMeshFirmwareResponse GetMeshFirmwareRequest packets because these are remnants of the old LIFX protocol. StateMeshFirmwareResponse causes issues when response packets are received because it has the same packet type as StateHostFirmwareResponse.
LifxLightDiscovery will now also detect and skip lights that are not yet supported by the binding.