Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-287: Add JSON support for serializing and deserializing AASX files #288

Merged
merged 2 commits into from
Apr 17, 2024
Merged

GH-287: Add JSON support for serializing and deserializing AASX files #288

merged 2 commits into from
Apr 17, 2024

Conversation

tobiaskraft
Copy link
Contributor

FrankSchnicke
FrankSchnicke requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@FrankSchnicke FrankSchnicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing this PR! I marked a few points during my review, would it be possible to address them?

...at-aasx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/AASXDeserializer.java Show resolved Hide resolved
...at-aasx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/AASXDeserializer.java Show resolved Hide resolved
...rmat-aasx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/AASXSerializer.java Show resolved Hide resolved
...ormat-aasx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/AASXValidator.java Show resolved Hide resolved
...ormat-aasx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/AASXValidator.java Outdated Show resolved Hide resolved
...asx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/MetamodelContentType.java Outdated Show resolved Hide resolved
@tobiaskraft
Copy link
Contributor Author

See Support for JSON by AASXDeserializer

Thank you very much for contributing this PR! I marked a few points during my review, would it be possible to address them?

Thanks for the review. I have reworked my code.

@FrankSchnicke FrankSchnicke merged commit 64e6ae4 into eclipse-aas4j:main Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjacoby mjacoby mjacoby left review comments

@FrankSchnicke FrankSchnicke FrankSchnicke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobiaskraft @mjacoby @FrankSchnicke