feat: implement asset information serialisation #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: restore the previous state
emildinchev
commented
Aug 30, 2023
| @@ -1,5 +1,6 @@ | |||
| /* | |||
There was a problem hiding this comment.
I have decided that it is better to decrease the class visibility to package-private. In such way the class is visible only from dataformat-json project. But it needs to be in the same package as ObjectMapperFactory.
emildinchev
commented
Aug 30, 2023
| @@ -0,0 +1,97 @@ | |||
| package org.eclipse.digitaltwin.aas4j.v3.dataformat.json; | |||
There was a problem hiding this comment.
In my opinion the ObjectMapper created by this class can fully replace the JsonSerializer and JsonDeserializer.
emildinchev
commented
Aug 31, 2023
| @@ -0,0 +1,15 @@ | |||
| package org.eclipse.digitaltwin.aas4j.v3.dataformat.xml; | |||
emildinchev
commented
Aug 31, 2023
| @@ -123,7 +123,7 @@ public void deserializeAASFullConceptDescription() throws FileNotFoundException, | |||
| @Test | |||
| public void deserializeAASWithExtensionMinimal() throws SerializationException, SAXException, FileNotFoundException, DeserializationException { | |||
| Environment env = new XmlDeserializer().read(XmlSerializerTest.AAS_WITH_EXTENSION_MINIMAL); | |||
|
|
|||
| //String xml = new XmlSerializer().write(env); | |||
There was a problem hiding this comment.
If you uncomment this line, the test will fail. This is a illustration of the bug: the XML serializer modifies the serialized object.
emildinchev
commented
Sep 1, 2023
| @@ -72,4 +72,18 @@ | |||
| <artifactId>jackson-core</artifactId> | |||
| </dependency> | |||
| </dependencies> | |||
| <build> | |||
There was a problem hiding this comment.
This is needed to ensure the execution of the tests in the given order (XMLSerializerTest should be at the end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.