Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hard coded api urls with templated links #5168

Merged
merged 1 commit into from May 15, 2024

Conversation

bb1950328
Copy link
Contributor

fixes #977
successfully tested by verifying that all mounted() functions are called at least once and checking that the api calls still work by doing the corresponding action in the ui

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.
Tested it locally, all dialoges still work and the href does not lead to an additonal request.

@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label May 12, 2024
Copy link

github-actions bot commented May 12, 2024

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this make sense to move these individual mounted definitions to the DialogBase and provide the key, as the mounted call is identical?

@pmattmann
Copy link
Member

Wouldn't this make sense to move these individual mounted definitions to the DialogBase and provide the key, as the mounted call is identical?

This PR exactly fulfills the issue #977
I therefore suggest that we merge this PR as it is - and that you create a new issue with your concern.

@pmattmann pmattmann added Meeting Discuss Am nächsten Core-Meeting besprechen and removed deploy! Creates a feature branch deployment for this PR labels May 13, 2024
@usu usu enabled auto-merge May 15, 2024 19:37
@manuelmeister manuelmeister dismissed their stale review May 15, 2024 19:39

Core Decision: Can be refactored later

@BacLuc BacLuc removed the Meeting Discuss Am nächsten Core-Meeting besprechen label May 15, 2024
@usu usu added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@BacLuc BacLuc added this pull request to the merge queue May 15, 2024
Merged via the queue into ecamp:devel with commit fa1f708 May 15, 2024
55 of 56 checks passed
@bb1950328 bb1950328 deleted the replace-hardcoded-api-urls branch May 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace hardcoded entityUris in dialogs with templated links
4 participants