New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change from php-fpm to frankenphp #5123
base: devel
Are you sure you want to change the base?
Conversation
Very cool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just some questions.
Also worked locally on my machine.
(linux with phpstorm)
|
||
RUN set -eux; \ | ||
install-php-extensions \ | ||
@composer \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the version of composer is not explicit anymore.
ok for me
COPY --link docker/php/docker-healthcheck.sh /usr/local/bin/docker-healthcheck | ||
RUN chmod +x /usr/local/bin/docker-healthcheck | ||
# Dev FrankenPHP image | ||
FROM frankenphp_base AS frankenphp_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, here is the frankenphp_dev branch
Fixes #4453
Changes from php-fpm to frankenphp + take over any other useful change from official api-platform template.
For a diff of all upstream changes since our last sync see
api-platform/api-platform@7642f86...v3.3.2
Open To Dos:
Excluded from this PR:
rfc_7807_compliant_errors
(upstream istrue
; kept atfalse
)validate_xml_mapping
(upstream istrue
; kept atfalse
)phpdocumentor/reflection-docblock
tophpstan/phpdoc-parser
(this generated wrong API responses; didn't debug further)docker-compose.yml
is nowcompose.yml
;api-platform.ini
is nowapp.ini
; etc.)xdebug
In upstream, the default working folder has changed from
/srv/api
to/app
.In order for debugging to work again, I had to change the
pathMappings
in my debug config in VScode.In other IDEs, something similar might be needed in order to find the correct sources.
Alterative would be that we stick to
/srv/api
instead of/app
.Old
.vscode/launch.json
:New
.vscode/launch.json
: