Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded entityUris in dialogs with templated links #977

Closed
1 of 5 tasks
carlobeltrame opened this issue Feb 16, 2021 · 4 comments · Fixed by #5168
Closed
1 of 5 tasks

Replace hardcoded entityUris in dialogs with templated links #977

carlobeltrame opened this issue Feb 16, 2021 · 4 comments · Fixed by #5168
Labels
Good first issue type: Frontend
Projects
Development
Milestone
MVP (v3.0)

Comments

@carlobeltrame
Copy link
Member

carlobeltrame commented Feb 16, 2021 •
edited

In files:

  • DialogMaterialItemCreate.vue -> /material-items
  • DialogActivityCreate.vue -> /activities
  • DialogCategoryCreate.vue -> /categories
  • DialogMaterialListCreate.vue -> /material-items
  • DialogPeriodCreate.vue -> /periods

The URIs can be retrieved from the API as follows: this.api.href(this.api.get(), 'materialItems').then(uri => { this.entityUri = uri }).
If the root api endpoint does not have some of them already, they can be added in the method apiAction() in IndexController.php.
@carlobeltrame carlobeltrame added this to the MVP (v3.0) milestone Feb 16, 2021
@carlobeltrame carlobeltrame added this to Backlog (all) in Development via automation Feb 16, 2021
@feigenmann
Copy link
Collaborator

would takle this

@carlobeltrame
Copy link
Member Author

Go for it

@carlobeltrame
Copy link
Member Author

carlobeltrame commented Jul 29, 2021 •
edited

This ticket needs to be re-specified once we are up and running with API Platform. Right now the description is out of date.

@carlobeltrame
Copy link
Member Author

In the meantime, the API is fully-featured again, and this issue can be implemented, based on the issue description.

bb1950328 added a commit to bb1950328/ecamp3 that referenced this issue May 11, 2024
@bb1950328
replace hard coded api urls with templated links
15b2eec 
fixes ecamp#977
@bb1950328 bb1950328 mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue type: Frontend
Projects
No open projects
Development
  
Backlog (all)
Milestone
MVP (v3.0)
Development

Successfully merging a pull request may close this issue.

replace hard coded api urls with templated links bb1950328/ecamp3
2 participants
@carlobeltrame @feigenmann