Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021 02 proteomes model changes #286

Merged
merged 9 commits into from
Feb 23, 2021

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Feb 22, 2021

Purpose

Reflect proteomes API model changes in the front end codebase

Approach

  • Namespace: proteomeproteomes
  • As directed by backend several proteomes attributes in the response are optional:
    • components
    • genomeAssembly
    • genomeAssemblyUrl
  • Added level to GenomeAssembly type (which represents Genome representation)
  • Rank enum added to taxonLineage and displayed in column renderer (more to be done for this and is covered in https://www.ebi.ac.uk/panda/jira/browse/TRM-25206)
  • Converted mock data to TS (had to use a globally unique name for the file [bug] duplicate manual mock found in separate directories jestjs/jest#2070)
  • Added top level redundantTo and isolate fields
  • exclusionReasons excluded from mock data for the reason that excluded proteomes are not indexed. Leo pretty sure of this but will check with Katie to confirm and I will update if it turns this is not the case.
  • Label change: Genome representation (RefSeq)Genome representation

Testing

Update existing snapshots

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why

Copy link
Member

@aurel-l aurel-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some linting changes (but eslint is not being run on files not yet covered by TS)

src/proteomes/components/__tests__/AccessionView.spec.tsx Outdated Show resolved Hide resolved
src/proteomes/components/__tests__/AccessionView.spec.tsx Outdated Show resolved Hide resolved
dlrice and others added 3 commits February 23, 2021 13:45
Co-authored-by: Aurélien Luciani <aurel-l@users.noreply.github.com>
Co-authored-by: Aurélien Luciani <aurel-l@users.noreply.github.com>
@dlrice dlrice merged commit 9d18fa2 into 2021_02-uniref-model-changes Feb 23, 2021
@dlrice dlrice deleted the 2021_02-proteomes-model-changes branch February 23, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants