-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021 02 proteomes model changes #286
Merged
dlrice
merged 9 commits into
2021_02-uniref-model-changes
from
2021_02-proteomes-model-changes
Feb 23, 2021
Merged
2021 02 proteomes model changes #286
dlrice
merged 9 commits into
2021_02-uniref-model-changes
from
2021_02-proteomes-model-changes
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurel-l
reviewed
Feb 22, 2021
aurel-l
requested changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some linting changes (but eslint is not being run on files not yet covered by TS)
Co-authored-by: Aurélien Luciani <aurel-l@users.noreply.github.com>
Co-authored-by: Aurélien Luciani <aurel-l@users.noreply.github.com>
aurel-l
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Reflect proteomes API model changes in the front end codebase
Approach
proteome
→proteomes
redundantTo
andisolate
fieldsexclusionReasons
excluded from mock data for the reason that excluded proteomes are not indexed. Leo pretty sure of this but will check with Katie to confirm and I will update if it turns this is not the case.Genome representation (RefSeq)
→Genome representation
Testing
Update existing snapshots
Checklist