Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testthat helper state #465

Merged
merged 10 commits into from
Jun 3, 2024
Merged

Add testthat helper state #465

merged 10 commits into from
Jun 3, 2024

Conversation

etiennebacher
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (f044e18) to head (0a8d4e6).
Report is 11 commits behind head on main.

Current head 0a8d4e6 differs from pull request most recent head 79c22c1

Please upload reports for the commit 79c22c1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   90.73%   90.34%   -0.40%     
==========================================
  Files          75       73       -2     
  Lines        5809     5696     -113     
==========================================
- Hits         5271     5146     -125     
- Misses        538      550      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil
Copy link
Member

There is one warning. Strange that the workflow isn't failing.

Warning (test-standardize_models.R:285:1): brms
Global state has changed:
names(before[[4]])[93:98] vs names(after[[4]])[93:100]
  "PERFLOG_LOCATION_SETTING"
  "PIPX_BIN_DIR"
  "PIPX_HOME"
  "PKGCACHE_HTTP_VERSION"
+ "PKG_CPPFLAGS"
+ "PKG_LIBS"
  "POWERSHELL_DISTRIBUTION_CHANNEL"
  "PROCESSX_PSXCINVC0FQM_1697110500"
  "PWD"                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
before[[4]][93:98] vs after[[4]][93:100]
  PERFLOG_LOCATION_SETTING"RUNNER_PERFLOG"
  PIPX_BIN_DIR"/opt/pipx_bin"
  PIPX_HOME"/opt/pipx"
  PKGCACHE_HTTP_VERSION"2"
+ PKG_CPPFLAGS"  -I\"/home/runner/work/_temp/Library/Rcpp/include/\"  -I\"/home/runner/work/_temp/Library/RcppEigen/include/\"  -I\"/home/runner/work/_temp/Library/RcppEigen/include/unsupported\"  -I\"/home/runner/work/_temp/Library/BH/include\" -I\"/home/runner/work/_temp/Library/StanHeaders/include/src/\"  -I\"/home/runner/work/_temp/Library/StanHeaders/include/\"  -I\"/home/runner/work/_temp/Library/RcppParallel/include/\"  -I\"/home/runner/work/_temp/Library/rstan/include\" -DEIGEN_NO_DEBUG  -DBOOST_DISABLE_ASSERTS  -DBOOST_PENDING_INTEGER_LOG2_HPP  -DSTAN_THREADS  -DUSE_STANC3 -DSTRICT_R_HEADERS  -DBOOST_PHOENIX_NO_VARIADIC_EXPRESSION  -DBOOST_NO_AUTO_PTR  -include '/home/runner/work/_temp/Library/StanHeaders/include/stan/math/prim/fun/Eigen.hpp'  -D_REENTRANT -DRCPP_PARALLEL_USE_TBB=1 "
+ PKG_LIBS" '/home/runner/work/_temp/Library/rstan/lib//libStanServices.a' -L'/home/runner/work/_temp/Library/StanHeaders/lib/' -lStanHeaders -L'/home/runner/work/_temp/Library/RcppParallel/lib/' -ltbb "
  POWERSHELL_DISTRIBUTION_CHANNEL"GitHub-Actions-ubuntu22"
  PROCESSX_PSXCINVC0FQM_1697110500"YES"
  PWD"/home/runner/work/datawizard/datawizard"
────────────────────────────────────────────────────────────────────────────────
```

@etiennebacher
Copy link
Member Author

Which workflow is this?

@etiennebacher
Copy link
Member Author

Actually, maybe this check-tests-warnings is broken? I removed all tests but one in datawizard and put a warning() call inside. Then I ran:

options(crayon.enabled = TRUE, warn = 2L)
devtools::test()

and it showed a test warning but not a failure

@IndrajeetPatil
Copy link
Member

Strange. This is what we used initially to detect test warnings

Will have a look.

Can you please create an issue in our workflows repository?

@etiennebacher
Copy link
Member Author

I see that all CI is passing now, @IndrajeetPatil can this be merged or are you experimenting with the warnings workflow?

@IndrajeetPatil IndrajeetPatil marked this pull request as draft October 17, 2023 11:47
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review May 26, 2024 16:42
@etiennebacher
Copy link
Member Author

So there's a bunch of CI failures for various reasons (#509, pak installation failures, Matrix issues, etc.) but none that are due to this PR so I merge this.

@etiennebacher etiennebacher merged commit 61f84c2 into main Jun 3, 2024
16 of 29 checks passed
@etiennebacher etiennebacher deleted the testthat-helper-state branch June 3, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants