Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a label to the task item html that indicates number of i… #1549

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

bZichett
Copy link

@bZichett bZichett commented Aug 31, 2023

Without this commit, it seems the UI simply does not surface this value until the task begins processing. I will also say this is one of my favorite aspects of easydiffusion (its queuing system is very well done and integrated.)

image

Questions:
Dev decision made to not show when ✕1, but this offsets the prompt differently from ✕2 or more from ✕1. Can always include this number (✕1) to 'fix' this minor UX issues, and maybe make it more washed out color wise (harder to see, more like a placeholder unless multi image.) OTOH, it may be nice to know that a task is going to produce batch images, but perhaps more important is prompt alignment (since many times, the prompt is the same in the beginning)

Note: Also included is a minor tweak. Not sure if it's a plugin I installed or if others see it differently but also included is a css patch for overriding the min-width: 50px from .drag-handle conflicting css. Could also rename the class to something different but for now this works fine. Without this fix it looks like this:

image

…mages enqueued (prior, it was unclear before task begins processing)
@bZichett
Copy link
Author

bZichett commented Aug 31, 2023

After thinking about above comments a bit more, probably a better UX to just always render the label (✕1) so prompts are aligned. Or even more clever, only begin rendering it when there has been a multi image job. Will hold on the amend until easy diffusion reviewers confirm that design makes more sense. Or others have some preference / idea on the above nuanced design decisions.

For example, another simpler idea might be to just move it to the left of Seed: ....

@bZichett
Copy link
Author

Ex:
image

@JeLuF
Copy link
Contributor

JeLuF commented Sep 3, 2023

Wouldn't it be sufficient to show this info in the taskinfo section, similar to seed, dimension, etc?

@bZichett
Copy link
Author

bZichett commented Sep 3, 2023

Yes, @JeLuF.

For example, another simpler idea might be to just move it to the left of Seed: ....

I had thrown a bunch of ideas above, and it really comes down to preference. I prefer it a bit more visible since I render with a lot of multi image jobs, and I like it looking like the Waiting / Processed label. It also makes more semantic sense to be to the left of the Job status as it reads well (ex: ✕5 - Enqueued) That being said, I wouldnt mind it being next to the seed either. It just needs to be somewhere (imo)

This commit can easily be changed to whatever the best UX compromise is.

@q5sys
Copy link

q5sys commented May 24, 2024

+1 on this, this is one of those small improvements I've been hoping would come for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants